Updater: fix update.sh parsing of latest version#4994
Merged
onetechnical merged 1 commit intoalgorand:masterfrom Jan 10, 2023
Merged
Updater: fix update.sh parsing of latest version#4994onetechnical merged 1 commit intoalgorand:masterfrom
onetechnical merged 1 commit intoalgorand:masterfrom
Conversation
onetechnical
requested review from
a team,
algobarb,
algojack,
algolucky and
excalq
Contributor
Author
|
This might have broken nightly updaters, as they can't run their update.sh! |
algolucky
approved these changes
Jan 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #4994 +/- ##
==========================================
- Coverage 53.63% 53.61% -0.03%
==========================================
Files 432 432
Lines 54057 54057
==========================================
- Hits 28996 28981 -15
- Misses 22818 22826 +8
- Partials 2243 2250 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
excalq
approved these changes
Jan 10, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the removal of S3 credential requirements, the updater script has an additional output line to indicate it's using anonymous credentials. This breaks the parsing of version. This changes the sed from counting lines to just taking the last line with tail.
Test Plan
Verify that nightly integration works properly.